sindresorhus / atom-editorconfig

Helps developers maintain consistent coding styles between different editors
https://atom.io/packages/editorconfig
MIT License
812 stars 80 forks source link

EditorConfig does not report any file inconsistencies based on the configuration file #243

Closed vizzale closed 1 year ago

vizzale commented 4 years ago

First of all thank you for your work.

I have two doubts, I still don't know if they are problems with the package or if it depends on my incorrect use. 1) If I create an .editorconfig file inside a project folder with files it already exists I know that changing the settings of the file these do not apply to existing files. But by opening these files should the system not at least notify me if there are inconsistencies with the .editorconfig file? 2) The second doubt is the following. I created an .editorconfig file, placed it inside a project folder, did some tests and I deleted the folder. Then I created a new folder and launched the "EditorConfig: Generate Config" command but the message "An .editorconfig file already exists in your project root." appears. Why does this error appear if I previously deleted the folder that contained it?

Thanks in advance for the help.

Involved .editorconfig-files

root = true

[*]
charset = utf-8
end_of_line = lf
indent_size = 2
indent_style = space
insert_final_newline = unset
max_line_length = 160
trim_trailing_whitespace = unset

[*.md]
trim_trailing_whitespace = false

Installed packages

Built-in Atom Packages (93)
├── atom-dark-syntax@0.29.1
├── atom-dark-ui@0.53.3
├── atom-light-syntax@0.29.1
├── atom-light-ui@0.46.3
├── base16-tomorrow-dark-theme@1.6.0
├── base16-tomorrow-light-theme@1.6.0
├── one-dark-ui@1.12.5
├── one-light-ui@1.12.5
├── one-dark-syntax@1.8.4
├── one-light-syntax@1.8.4
├── solarized-dark-syntax@1.3.0
├── solarized-light-syntax@1.3.0
├── about@1.9.1
├── archive-view@0.65.2
├── autocomplete-atom-api@0.10.7
├── autocomplete-css@0.17.5
├── autocomplete-html@0.8.8
├── autocomplete-plus@2.42.3
├── autocomplete-snippets@1.12.1
├── autoflow@0.29.4
├── autosave@0.24.6
├── background-tips@0.28.0
├── bookmarks@0.46.0
├── bracket-matcher@0.91.2
├── command-palette@0.43.5
├── dalek@0.2.2
├── deprecation-cop@0.56.9
├── dev-live-reload@0.48.1
├── encoding-selector@0.23.9
├── exception-reporting@0.43.1
├── find-and-replace@0.219.3
├── vizzaley-finder@1.14.1
├── github@0.34.1-3
├── git-diff@1.3.9
├── go-to-line@0.33.0
├── grammar-selector@0.50.1
├── image-view@0.64.0
├── incompatible-packages@0.27.3
├── keybinding-resolver@0.39.0
├── line-ending-selector@0.7.7
├── link@0.31.6
├── markdown-preview@0.160.2
├── metrics@1.8.1
├── notifications@0.71.0
├── open-on-github@1.3.2
├── package-generator@1.3.0
├── settings-view@0.261.3
├── snippets@1.5.0
├── spell-check@0.76.0
├── status-bar@1.8.17
├── styleguide@0.49.12
├── symbols-view@0.118.4
├── tabs@0.110.0
├── timecop@0.36.2
├── tree-view@0.228.0
├── update-package-dependencies@0.13.1
├── welcome@0.36.9
├── whitespace@0.37.7
├── wrap-guide@0.41.0
├── language-c@0.60.18
├── language-clojure@0.22.8
├── language-coffee-script@0.50.0
├── language-csharp@1.1.0
├── language-css@0.44.2
├── language-gfm@0.90.7
├── language-git@0.19.1
├── language-go@0.47.1
├── language-html@0.53.0
├── language-hyperlink@0.17.1
├── language-java@0.31.4
├── language-javascript@0.134.0
├── language-json@1.0.4
├── language-less@0.34.3
├── language-make@0.23.0
├── language-mustache@0.14.5
├── language-objective-c@0.16.0
├── language-perl@0.38.1
├── language-php@0.44.4
├── language-property-list@0.9.1
├── language-python@0.53.3
├── language-ruby@0.72.22
├── language-ruby-on-rails@0.25.3
├── language-rust-bundled@0.1.0
├── language-sass@0.62.1
├── language-shellscript@0.28.0
├── language-source@0.9.0
├── language-sql@0.25.10
├── language-text@0.7.4
├── language-todo@0.29.4
├── language-toml@0.20.0
├── language-typescript@0.6.0
├── language-xml@0.35.3
└── language-yaml@0.32.0

Community Packages (32) /Users/vizzale/.atom/packages
├── atom-beautify@0.33.4
├── atom-minify@0.8.0
├── auto-detect-indentation@1.3.0
├── autocomplete-paths@2.12.2
├── autoprefixer@4.2.0
├── busy-signal@2.0.1
├── color-picker@2.3.0
├── double-tag@1.7.0
├── editorconfig@2.6.0
├── emmet@2.4.3
├── file-icons@2.1.41
├── flex-tool-bar@2.2.0
├── highlight-selected@0.17.0
├── intentions@1.1.5
├── linter@2.3.1
├── linter-csslint@2.0.6 (disabled)
├── linter-htmlhint@1.6.3
├── linter-jshint@3.1.19
├── linter-php@1.6.1
├── linter-phpcs@1.7.6
├── linter-stylelint@4.5.0
├── linter-ui-default@1.8.1
├── minimap@4.29.9
├── minimap-highlight-selected@4.6.1
├── open-in-browser@0.5.2
├── pigments@0.40.2
├── rainbow-tabs@2.5.1
├── split-diff@1.6.1
├── sync-settings@4.3.3
├── sync-settings-folder-location@1.0.6
├── todo-show@2.3.2
└── tool-bar@1.3.0
Alhadis commented 4 years ago

What OS are you running, and what setting is File System Watcher configured with? Open SettingsCore and look for a field that looks like this:

Figure 1

The issue you're describing sounds like it might be an issue with Atom's ability to dispatch or respond to filesystem events (such as deleting or creating a file). Creating a new .editorconfig file should be all it takes to get the authored settings applied to project files. That is, this shouldn't be happening:

I know that changing the settings of the file these do not apply to existing files. But by opening these files should the system not at least notify me if there are inconsistencies with the .editorconfig file?

the-j0k3r commented 2 years ago

Hello

I have same/similar issue with an existing project

this is my editorconfig dot file

# https://github.com/editorconfig/editorconfig/wiki/EditorConfig-Properties
root = true

[*]
indent_style = space
indent_size = 4
tab_width = 4
trim_trailing_whitespace = true
end_of_line = lf
charset = utf-8
insert_final_newline = true

[*.css]
block_comment_start = /*
block_comment = *
block_comment_end = */

[*.styl]
block_comment_start = //
max_line_length = 80

[*.md]
trim_trailing_whitespace = false
block_comment_start = <!--
block_comment_end = -->

Creating a new .editorconfig file should be all it takes to get the authored settings applied to project files. That is, this shouldn't be happening:

I deleted and recreated the file with the changes below

indent_size = 2
tab_width = 2

And rerun editor config fix file or via eclint nothing happens and editor config happily reports nothing changed. Capture

If I change the indent style to tabs it changes everything to tabs but keeps the 4 and not 2, I tried similar workarounds to no avail.

OS is Windows 10 2004 pro workstation Atom 1.58.0 64 bit Atom is using Native Operating system APi's se in core.

Thanks in advance for your work on this project.

the-j0k3r commented 2 years ago

@Alhadis thoughts? on this. Im trying to avoid to create a whole new project to workaround this.

sindresorhus commented 1 year ago

Closing as Atom is abandoned.