Closed giacomocerquone closed 7 years ago
@marionebl Why are we depending on text-buffer
directly instead of using it from atom
?
Did that to avoid the direct dependency on the virtual "atom" package, which only exists as builtin in atom processes. This way we can do the unit tests without apm
.
Passed over it installing 0.21.0 When you'll solve this I'll update 😄 PS: Same problem also on my windows 10 desktop machine
I'd like to keep the unit tests somewhat independent of actual apm-started processes @sindresorhus. Perhaps we could revert to using the atom builtin and provide a mock based on text-buffer for it, moving the dependency on it to devDependencies? Perhaps this could do away with the rebuild steps on Tavis.
@marionebl Yes, let's do that. We shouldn't have anything in dependencies
that requires a native build-step.
@sindresorhus I think it would make sense to run tests on AppVeyor to avoid stuff like this in the future
Environment
OS: Windows 10 Atom -v:
Problem
Trying to install this linter through:
apm install linter-xo
This is what I get:PS = I was undecided if putting this huge error would have been a good thing. If it's too long I'll edit the issue.