search

sindresorhus / awesome-lint

Linter for Awesome lists
MIT License
600 stars 56 forks source link

Add apostrophe to word tokenization list allowing possessive forms #149

Closed janpeuker closed 1 year ago

janpeuker commented 2 years ago

Fixes #148

I would like to propose adding the apostrophe symbol for word tokenization, so that the linter does not complain on possessive forms.

The integration tests don't run locally for me (due to missing API access, happy to help fix that if someone can guide me). The local tests after my addition appear unchanged (no additional failures):

  6 warnings

  9 tests failed
  2 known failures

  rules › code-of-conduct › code-of-conduct - invalid if has placeholder
  rules › code-of-conduct › code-of-conduct - invalid if just copied

In order to clearly separate the added test from the tokenization change, I have not squashed local commits. Apologies if this PR does violate the Contribution Guidelines for that. I'm happy to help in the future and happy to learn from this issue to submit better PRs in the future.

sindresorhus commented 2 years ago

CI is failing

janpeuker commented 2 years ago

CI is failing

This appears to be the same reason I experienced locally, failing GitHub integration tests (tests fail in github.js). This seems to have happened in older commits in 2021, already e.g. this one, 2 different problems:

1) Local Tests can't possibly work because the canonical tests have symbolic links to GitHub, this probably only works with TravisCI

2) I don't fully understand github.js, because it looks stubbed but errors returned are like "Response code 404 (Not Found)" looking for a repo "sindresorhus/awesome-lint-test.git". I will see if I find out what the problem is once I learned the stubbing technique

FlakeysRay commented 1 year ago

That's what you still believe