search

sindresorhus / awesome-lint

Linter for Awesome lists
MIT License
611 stars 59 forks source link

Proposal: change remark-lint:no-dead-urls to warn instead of error #89

Open transitive-bullshit opened 5 years ago

transitive-bullshit commented 5 years ago

This seems to be tripping a lot of people up and there are a decent number of edge cases that will be difficult to resolve robustly in all cases (e.g., rate limits, IP blacklists when running from CI, temporary server outages, etc).

See https://github.com/transitive-bullshit/check-links/issues/4 for the main issue where many authors have included their false negatives. Also see #88, #85, #50, and numerous other issues raised that are referenced in https://github.com/transitive-bullshit/check-links/issues/4.

My proposal would be to make these warnings instead of hard errors.

sindresorhus commented 5 years ago

Sure

chinesedfan commented 4 years ago

The rule has been removed in https://github.com/sindresorhus/awesome-lint/releases/tag/v0.13.0, so this issue can be closed now.

fregante commented 2 years ago

If anyone wants to still check for dead URLs, I suggest trying lychee as a scheduled workflow:

https://github.com/fregante/Awesome-WebExtensions/blob/main/.github/workflows/link-checker.yml

It will automatically open an issue when it finds a broken URL. Using it as a schedule workflow also avoids occasionally failing new PRs for pre-existing broken URLs.

andy5995 commented 2 years ago

The rule has been removed in https://github.com/sindresorhus/awesome-lint/releases/tag/v0.13.0, so this issue can be closed now.

readme needs updating https://github.com/sindresorhus/awesome-lint#special-comments