search

sindresorhus / awesome-nodejs

:zap: Delightful Node.js packages and resources
https://node.cool
Creative Commons Zero v1.0 Universal
57.56k stars 5.81k forks source link

Validate that links are up (once a week) #1172

Closed simeg closed 2 years ago

simeg commented 2 years ago

Every Sunday at midnight this Github action will validate that all http/https links responds with 200. If a link has been permanently removed (or just moved) it can be removed/changed which leads to a higher quality list.

This check is already in place in the mac-setup0 repo and is working well. It won't prevent any PRs from getting merged, and optionally a badge can be added to the README to highlight the link status (see mac-setup repo).

Hi @sindresorhus! I'm curious what you think of my suggestion. I think this will increase the quality of this nice repo! 🙂 It will make commits like this one easier to create as the workflow will figure out what URLs are != 200.

simeg commented 2 years ago

Note that on the first run it may trigger some 429s and other things that will need tweaking.

simeg commented 2 years ago

@sindresorhus You need to activate Github actions, or allow this action to be run. Or perhaps it's active just that I'm not seeing the results?

sindresorhus commented 2 years ago

Yeah, I have activated actions now. It will run next Sunday then.

sindresorhus commented 2 years ago

@simeg It's unclear to me why it's failing now: https://github.com/sindresorhus/awesome-nodejs/runs/6243287642?check_suite_focus=true

simeg commented 2 years ago

@sindresorhus It's being rate limited by Github.com, hence the 429 response codes. For now we can ignore 429 codes if you'd like. I think it's solvable by passing a GITHUB_TOKEN, just gotta find some time to implement it.