sindresorhus / awesome-scifi

Sci-Fi worth consuming
Creative Commons Zero v1.0 Universal
4.21k stars 256 forks source link

The Link to Book 5 of Magic 2.0 is incorrect #260

Closed EricPonvelle closed 5 years ago

EricPonvelle commented 5 years ago

Currently, the link for "Out of Spite, Out of Mind" links to this - https://www.goodreads.com/book/show/36566205-fight-and-flight. This is a duplicate of the previous book link.

It should link here - https://www.goodreads.com/book/show/39751936-out-of-spite-out-of-mind

image

RichardLitt commented 5 years ago

Thanks for pointing this out! If you'd like to make a PR fixing it, I'd be happy to review it.

EricPonvelle commented 5 years ago

Sure thing! Are there permissions that I am lacking? I got this error when I tried to commit

C:\awesome-scifi>git push -u origin HEAD
remote: Permission to sindresorhus/awesome-scifi.git denied to EricPonvelle.
fatal: unable to access 'https://github.com/sindresorhus/awesome-scifi.git/': The requested URL returned error: 403
RichardLitt commented 5 years ago

Looks like you need to fork the repo and create a PR from your own branch. :)

EricPonvelle commented 5 years ago

It was way easier to just edit in the browser in the end. Still having issues with local git. Here's the PR!

https://github.com/sindresorhus/awesome-scifi/pull/261#issue-221576476

RichardLitt commented 5 years ago

:) Thanks.