search

sindresorhus / camelcase-keys

Convert object keys to camel case
MIT License
691 stars 95 forks source link

Option 'deep' does nothing in 6.2.1 #57

Closed lami02 closed 3 years ago

lami02 commented 4 years ago

Hi, in release 6.2.1 the Option 'deep' does nothing.

camelcaseKeys({a_b: {c_d: 1}}, {deep:true}) //=> {aB: {c_d: 1}}

I tested 6.1.2 and in that release everything was fine.

sindresorhus commented 4 years ago

There were no actual JS changes between those versions: https://github.com/sindresorhus/camelcase-keys/compare/v6.1.2...v6.2.1

russcarver commented 3 years ago

Same issue in 6.2.2. Downgrading to 6.1.2 solved it. Please fix.

aguynamedben commented 3 years ago

FWIW I thought this was happening to me, but after adding some console.log's directly after camelizeKeys is called, I realized the cause was a poorly implemented redux action that was dropping the update based on a matching uuid. I have synced to redux without { deep: true } present, and subsequent syncs with { deep: true } were being incorrectly dropped by my redux action.

image

{ deep: true } on 6.2.2 works as expected for me. Thanks for all the work you do 🙏 I love that I found this library, and the other ones you manage.