search

sindresorhus / capture-website-cli

Capture screenshots of websites from the command-line
MIT License
821 stars 42 forks source link

Incorrect documentation for executable in docker #9

Closed AlmogCohen closed 5 years ago

AlmogCohen commented 5 years ago

When installed into docker, the package name is webcapture and not website-capture as stated in the main readme.

sindresorhus commented 5 years ago

That is incorrect: https://github.com/sindresorhus/capture-website-cli/blob/f041897098b0af8421b36e008238934319a87e42/package.json#L12-L14

You probably have some other tool installed or something else.

AlmogCohen commented 5 years ago

I checked again and what I've wrote is correct :) I just confirmed with Docker installation with this npm package installed alone.

I figured out that the issue could stem from the fact that the version on npm is 0.1.0 and not 0.2.0 as I can see released on this repo.

Please fix :)

AlmogCohen commented 5 years ago

Yes, I can confirm that this is indeed an issue with the outdated package in npm.

After installing the latest 0.2.0 release with npm install https://github.com/sindresorhus/capture-website-cli.git#f041897098b0af8421b36e008238934319a87e42 the issue was solved. And the proper executable is indeed found...