search

sindresorhus / create-dmg

Create a good-looking DMG for your macOS app in seconds
MIT License
4.72k stars 196 forks source link

Installing graphicsmagick and imagemagick for the dmg icon generation in Github Actions is unbearably slow #57

Open bjesuiter opened 4 years ago

bjesuiter commented 4 years ago

I integrated your create-dmg tool into my github actions workflow: https://github.com/bjesuiter/macos-file-summoner/blob/master/.github/workflows/go.yml

However, when installing imagemagic and graphicsmagick, the automated build takes ages longer than without them, because they are so big.

I tried to combat this by using gihub cache actions and caching the homebrew cache dir, but since this thing has 2,4 gb this is also painfully slow.

Could you implement another solution which is more lightweight to update this dmg icon?

bjesuiter commented 4 years ago

Please see this run of the workflow for checking homebrew cache sizes and timings: https://github.com/bjesuiter/macos-file-summoner/runs/789695326?check_suite_focus=true

(This run threw an error because of a missing code signing identity, but I simply forgot to load my dev identity there)

sindresorhus commented 4 years ago

Yes, it could be implemented as a simple Swift binary using CoreGraphics. However, it’s not something I have time to work on, but pull request welcome.

bjesuiter commented 4 years ago

Thanks for looking into the issue! Unfortunately, I don't have any experience with swift, I recently started with this File Summoner App written in go and packaged manually as MacOS App Package.

But maybe this can be my starting point with swift 👍