Build version not matching version in package.json

sindresorhus / create-dmg

Create a good-looking DMG for your macOS app in seconds

MIT License

4.72k stars 196 forks source link

Build version not matching version in package.json #60

Closed aubreypwd closed 10 months ago

aubreypwd commented 4 years ago

When I bump the version in package*.json and I run, e.g.

./node_modules/.bin/create-dmg './build/Twitter-darwin-x64/Twitter.app' --overwrite --dmg-title='Twitter' --identity='Aubrey Portwood' ./dist/"

The version in dist/ is always 1.0.0.

fcastilloec commented 3 years ago

Did you rebuild it with electron-packager after updating the version? This module doesn't use the info on your package.json directly, it uses the info of the package.json inside of your packaged app

aubreypwd commented 3 years ago

I did not, I have used it successfully to package a folder with a .app in it that get's built by nativefier. I will look into this more and report back if I can.