search

sindresorhus / create-dmg

Create a good-looking DMG for your macOS app in seconds
MIT License
4.72k stars 196 forks source link

License addition doesn't work on macOS Big Sur #62 #66

Closed dxdc closed 3 years ago

dxdc commented 3 years ago

Was able to port hdiutil from macOS 10.15 to work on Big Sur, but required copying over the DiskImages.framework and editing the library path within hdiutil. As such, the code signature for hdiutil is not valid anymore.

In case you want to build this yourself, starting with Apple's native hdiutil, instead of the version I supplied:

install_name_tool -change "/System/Library/PrivateFrameworks/DiskImages.framework/Versions/A/DiskImages" "@executable_path/DiskImages.framework/Versions/A/DiskImages" hdiutil
codesign --remove-signature hdiutil
codesign -s - hdiutil

The framework is fully codesigned (not edited).

Can confirm this all works smoothly on macOS Big Sur. Maybe not a great permanent solution, but it works in the short term.

sindresorhus commented 3 years ago

I appreciate the effort, but I'm not going to merge this. It's huge, hacky, and dubious from a legal perspective whether it's allowed to include an Apple framework like this.

Also, there's a known solution to this problem: https://developer.apple.com/forums/thread/668084

sindresorhus commented 3 years ago

I suggest you link to your fork in https://github.com/sindresorhus/create-dmg/issues/62 for someone looking for an immediate solution.