search

sindresorhus / create-dmg

Create a good-looking DMG for your macOS app in seconds
MIT License
4.72k stars 196 forks source link

Replace ora.fail with ora.warn and remove exit status: 2 when no code signing authority is present #75

Closed rishaan05 closed 1 year ago

rishaan05 commented 2 years ago

Exit status 2 can cause multi-step build scripts to fail for potentially normal use since code signing certificates are not necessarily required.

sindresorhus commented 2 years ago

That's why it exits with code 2 and not 1. So it can be detected: https://github.com/sindresorhus/create-dmg/issues/24

I'm worried that failing silently, means that someone having it in a build script can accidentally ship unsigned DMGs to users.