Don't set dmg icon - Githubissues

sindresorhus / create-dmg

Create a good-looking DMG for your macOS app in seconds

MIT License

4.72k stars 196 forks source link

Don't set dmg icon #89

Closed Cykelero closed 10 months ago

Cykelero commented 10 months ago

Currently, create-dmg assigns the icon that it generates both to the disk image volume, and to the DMG itself. I think this is somewhat confusing, as the generated icon represents a volume, not a file.

This PR removes the code that assigns a custom icon to the DMG file.

Currently	With PR

sindresorhus commented 10 months ago

I agree. This was a wrong choice.

Cykelero commented 10 months ago

Thank you :)