search

sindresorhus / dark-mode

Control the macOS dark mode from the command-line
MIT License
661 stars 28 forks source link

reset functionality added #5

Closed justijndepover closed 7 years ago

justijndepover commented 7 years ago

Added an argument to remove the defaults AppleInterfaceStyle key.

sindresorhus commented 7 years ago

Why? Can you elaborate on the use-case? :)

justijndepover commented 7 years ago

Your code contains an error if you set the mode to Light or Dark. Once you've set a specific mode with your program, and you try to change it via system preferences, it leaves your system in a mixed state (hence the following issue: https://github.com/sindresorhus/dark-mode/issues/3)

With the added reset you can change the mode back to normal (before it was broken)

sindresorhus commented 7 years ago

I appreciate the pull request, but I went with fixing the problem for real. See: https://github.com/sindresorhus/dark-mode/releases/tag/2.0.0

chemzqm commented 7 years ago

Thank god, the panda.app works. Hope I didn't install this tool from homebrew.