sindresorhus / df

Get free disk space info from `df -kP`
MIT License
64 stars 12 forks source link

Probably build issue when building on travis CI #1

Closed icyflame closed 9 years ago

icyflame commented 9 years ago

This is the screenshot that led me here :-

image

The build can be found here

It is mentioned that the package causing an issue is a dependency of mount-point. So, I believe the problem is with mount-point which declares @sindresorhus/df as a dependency.

I am using xdg-basedir and trash packages, due to which these packages enter the dependency tree.

Is this problem because of the presence of @ in the package name?

Weirdly enough, the same build worked fine on Node 0.11 and Node 0.12. Link to Node 0.11 build Link to Node 0.12 build

shinnn commented 9 years ago

https://twitter.com/othiym23/status/593653282272194560

Just upgrade npm to the latest version before npm install.

icyflame commented 9 years ago

@shinnn Updating NPM before installing worked! Thanks!

icyflame commented 9 years ago

@shinnn

Updating NPM did work, but since this is an issue that I am facing again and again with Travis Builds, now, it is getting annoying.

Please look at the discussion here : https://github.com/kevva/mount-point/pull/3

I would really like for you to fix this, by setting the minimum npm version in this package so that it works across it's dependents. I would do it myself, but I don't know how, and @kevva has not responded.

**

cc / @sindresorhus

sindresorhus commented 9 years ago

The engine field is not enforced, so that wouldn't help unfortunately.

icyflame commented 9 years ago

@sindresorhus

That's what my tests has proved too. :cry:

I thought I was doing something wrong! But is there no way at all to fix this?

sindresorhus commented 9 years ago

Answered in https://github.com/kevva/mount-point/pull/3#issuecomment-119683273