search

sindresorhus / editorconfig-sublime

Sublime Text plugin for EditorConfig - Helps developers maintain consistent coding styles between different editors
MIT License
1.77k stars 108 forks source link

Notification when opening a file that has incorrect line endings #5

Closed Iristyle closed 11 years ago

Iristyle commented 11 years ago

Again, another idea taken from https://github.com/SublimeText/LineEndings

Use case...

I'm about to do some hacking on a repo with LF endings (on Windows). Somehow, a file sneaks in with CRLF endings. When I open that file, I want to know right away that I should save / commit this file, so that when I start making real commits, they don't get lost in whitespace noise.

I already get a bit of this by using Modific which supports gutter marks for file changes... but it might be nice to totally get the Gong up-front.

treyhunner commented 11 years ago

I like this idea. I think other plugins should consider adopting it too.

@xuhdev What do you think about this?

xuhdev commented 11 years ago

I also like this idea. We can try our best to support it. But I think some people may also dislike it? So maybe we can add a switch for the plugins on this feature.

On Sep 20, 2012, at 9:15, Trey Hunner notifications@github.com wrote:

I like this idea. I think other plugins should consider adopting it too.

@xuhdev What do you think about this?

— Reply to this email directly or view it on GitHub.

sindresorhus commented 11 years ago

Hmm, not sure about this, it kinda defeats the purpose of doing its thing transparently in the background.

@Iristyle When you open a file with wrong line endings it will be marked as dirty right away. That's how you know changes has been applied. Is that not good enough?

Iristyle commented 11 years ago

I agree @sindresorhus that non-intrusive notification methods are better, when possible.

I think that Modific does immediately show the gutter marks when Sublime opens a file and reformats based on EditorConfig rules.

The only problem is that this requires Modific. Maybe the most appropriate thing to do then is add something to the readme about installing Modific.

It would be nice to have an option though for people who don't want to install Modific (or don't use the systems that Modific supports - Git and Hg only IIRC)