search

sindresorhus / editorconfig-sublime

Sublime Text plugin for EditorConfig - Helps developers maintain consistent coding styles between different editors
MIT License
1.77k stars 108 forks source link

Plugin should respect current file settings #54

Open heptal opened 8 years ago

heptal commented 8 years ago

The current window setting should supersede the settings in .editorconfig

Let's say .editorconfig says to indent using spaces. When I edit a file and uncheck 'Indent Using Spaces' in the UI: And Convert Indentation to Tabs: Upon save it uses the .editorconfig settings instead of the UI setting I just set before saving to disk, and then reverts it:

This forces me to temporarily disable the plugin or edit my .editorconfig just to save a file with a non-normal indentation configuration.

kevva commented 8 years ago

This was added in https://github.com/sindresorhus/editorconfig-sublime/pull/19 due to new files not getting the settings from .editorconfig, and I think this is the expected behavior tbh.

heptal commented 8 years ago

Hmm, well that issue talks about using on_post_save, but the revert happens before save.