search

sindresorhus / editorconfig-sublime

Sublime Text plugin for EditorConfig - Helps developers maintain consistent coding styles between different editors
MIT License
1.77k stars 107 forks source link

Disable EditorConfig console output by default #67

Closed ghost closed 7 years ago

ghost commented 7 years ago

Closes #62

GrayHatter commented 7 years ago

👎 I would never have learned this was the reason all my files were getting broken. The default should be to output when it's clobbering all files.

ghost commented 7 years ago

@GrayHatter EditorConfig can break your files? It just sets proper settings per view. Also this PR just hides logging, but not the exceptions if they occurs during the execution.

GrayHatter commented 7 years ago

UTF-8 + BOM, tabs, and CRLF, are not proper. And if the defaults we're printed, I'd never have figured out it was editorconfig that was breaking my shit.

And if you don't beleve me, save subl3's user prefrences with UTF8 + BOM with CRLF, and tell me this isn't horribly broken.

aziz commented 7 years ago

I think this PR should be merged ASAP, even if you want to keep the default "debug" value to True and print by default, it should be possible to turn it off in user settings.

Printing something (that is not an exception) to console without letting users to turn it off, is just rude and wrong.

@sindresorhus please merge this PR.

sindresorhus commented 7 years ago

I'm getting an error message when trying to open the config file from the Package Control menu.

screen shot 2017-06-09 at 16 36 24

It should also have an entry for both default and user settings, like all other plugins.

ghost commented 7 years ago

@sindresorhus I have just checked the code, everything should work fine. I can add separate menu items for Default & User settings, but what's wrong with the new settings command introduced in Sublime Text 3116?

sindresorhus commented 7 years ago

Never mind. It's all good.