search

sindresorhus / editorconfig-sublime

Sublime Text plugin for EditorConfig - Helps developers maintain consistent coding styles between different editors
MIT License
1.77k stars 107 forks source link

Upgrade to ST3 #8

Closed paulmillr closed 11 years ago

sindresorhus commented 11 years ago

I'm planning on upgrading the plugin, but want to wait a few weeks so they have the chance to work out the worst bugs.

revathskumar commented 11 years ago

:+1:

dotcypress commented 11 years ago

I'm already port plugin. Now i need cleanup code and i can send pull request.

sindresorhus commented 11 years ago

@dotCypress hah, that's awesome! Make sure you use the new async APIs in ST3 and make it pure Py3. I'm fine with maintaining two versions for the time being.

Sidenote: The Editorconfig lib used isn't upgraded to Py3 yet, so how did you make that work?

Also, so not to mock with the ST2 plugin which uses the master branch, the ST3 one should go on its own branch ('st3').

dotcypress commented 11 years ago

I changed Editorconfig lib a little.

sindresorhus commented 11 years ago

k, cool. make sure those changes makes it upstream ;)

treyhunner commented 11 years ago

The editorconfig/editorconfig-core-py#2 pull request supports Python 3 as of 8 hours ago.

I plan to merge it into master and release versions 0.12.0 today.

dotcypress commented 11 years ago

Awesome.

sindresorhus commented 11 years ago

Fixed in https://github.com/sindresorhus/editorconfig-sublime/commit/ecbbf1d57282eb6044a62a606391ad22234f11d0