search

sindresorhus / editorconfig-sublime

Sublime Text plugin for EditorConfig - Helps developers maintain consistent coding styles between different editors
MIT License
1.77k stars 108 forks source link

Don't break `git commit --verbose` #88

Closed vogu66 closed 4 years ago

vogu66 commented 4 years ago

Fixes #55 by making the line endings into "lf" for all files into .git folders.

IssueHunt Summary ### Referenced issues This pull request has been submitted to: - [#55: Breaks git commit -v (git commit --verbose)](https://issuehunt.io/repos/4501025/issues/55) ---
sindresorhus commented 4 years ago

The PR title could be better.

vogu66 commented 4 years ago

My horrible naming sense doesn't give me any insight on how to change that PR name, although I agree it's not pretty

vogu66 commented 4 years ago

Also, as I said in the issue, I don't have access to a Mac so I can't test whether it works on Mac -- although I would be really surprised if it didn't, since git uses Unix line endings on Windows, there is no reason for it not to use them on Mac. I could be wrong, though.

Now, unlike the long procedure I mentioned in the issue, I suppose it would be simpler to just create an empty git repo, open the .git/config file, and check with an editor that doesn't automatically change the line ending (like, I believe, Sublime Text when the editorconfig plugin is deactivated) whether it is indeed lf or Unix. Or if someones knows for a fact that it is, I guess it's fine too.

sindresorhus commented 4 years ago

My horrible naming sense doesn't give me any insight on how to change that PR name, although I agree it's not pretty

Just a short sentence of what this PR fixes