sindresorhus / editorconfig-sublime

Sublime Text plugin for EditorConfig - Helps developers maintain consistent coding styles between different editors
MIT License
1.77k stars 108 forks source link

ST3 support #9

Closed dotcypress closed 11 years ago

dotcypress commented 11 years ago

I decide to use on_pre_save instean on_pre_save_async because we need to change charset before save operation.

on_load chaged to on_load_async

And new version of editorconfig is included

dotcypress commented 11 years ago

Ready

sindresorhus commented 11 years ago

I tried this out on latest ST3 build and got this error when saving a file:

Traceback (most recent call last):
  File "/Users/sindresorhus/Downloads/Sublime Text.app/Contents/MacOS/sublime_plugin.py", line 238, in on_pre_save
    callback.on_pre_save(v)
  File "/Users/sindresorhus/Library/Application Support/Sublime Text 3/Packages/editorconfig-sublime/EditorConfig.py", line 23, in on_pre_save
    self.init(view, True)
  File "/Users/sindresorhus/Library/Application Support/Sublime Text 3/Packages/editorconfig-sublime/EditorConfig.py", line 30, in init
    config = get_properties(path)
  File "/Users/sindresorhus/Library/Application Support/Sublime Text 3/Packages/editorconfig-sublime/editorconfig/__init__.py", line 15, in get_properties
    return handler.get_configurations()
  File "/Users/sindresorhus/Library/Application Support/Sublime Text 3/Packages/editorconfig-sublime/editorconfig/handler.py", line 82, in get_configurations
    self.preprocess_values()
  File "/Users/sindresorhus/Library/Application Support/Sublime Text 3/Packages/editorconfig-sublime/editorconfig/handler.py", line 113, in preprocess_values
    not "indent_size" in opts and self.version >= VERSION[:3]):
TypeError: unorderable types: NoneType() >= tuple()
Writing file /Users/sindresorhus/Library/Application Support/Sublime Text 3/Packages/editorconfig-sublime/readme.md with encoding UTF-8 (atomic)
dotcypress commented 11 years ago

Give me pls .editorconfig file for this issue

sindresorhus commented 11 years ago

@dotCypress the one in this repo

dotcypress commented 11 years ago

Seem like editorconfig lib bug :bug: Fixed.

sindresorhus commented 11 years ago

Awesome! Thanks for doing upgrading this :)

Make sure to send the lib fix upstream.