search

sindresorhus / electron-context-menu

Context menu for your Electron app
MIT License
1.37k stars 153 forks source link

"Download" actions do not work in webviews #122

Open GiovanH opened 3 years ago

GiovanH commented 3 years ago

"Download" actions pass the webview as a window to electron-dl, but electron-dl does not support webviews. Electron-dl would need to change its specification or electron-context-menu should pass the parent window instead.

sindresorhus commented 3 years ago

I think this should be fixed in electron-dl.

GiovanH commented 3 months ago

Is there any reason electron-context-menu shouldn't pass the parent window as suggested, at least as a stopgap measure? Perhaps along with a console warning describing the behavior.