search

sindresorhus / electron-dl

Simplified file downloads for your Electron app
MIT License
1.15k stars 138 forks source link

Use `ses.downloadURL(url)` #104

Open sindresorhus opened 4 years ago

sindresorhus commented 4 years ago

Electron 8 added a new useful API: https://github.com/electron/electron/pull/19889/files

We should use it for electronDl.download().

sindresorhus commented 1 year ago

If anyone wants to work on this, see the initial attempt in https://github.com/sindresorhus/electron-dl/pull/138

mquevill commented 1 month ago

It seems like using webContents.downloadURL is the preferred method according to Electron's session docs:

Note: This does not perform any security checks that relate to a page's origin, unlike webContents.downloadURL.