search

sindresorhus / electron-store

Simple data persistence for your Electron app or module - Save and load user preferences, app state, cache, etc
MIT License
4.57k stars 148 forks source link

Upgrade dot-prop dependencies to v7 #265

Open raphaelmenges opened 1 year ago

raphaelmenges commented 1 year ago

Hello 👋

To my understanding, you, @sindresorhus, use internally your own package dot-prop? According to my package-lock.json, that package is included as "dot-prop": "^6.0.1". However, I need to access array items by index using dot notation for store migration between versions. This seems to be a feature that you added in version 7 of dot-prop. Could you upgrade the (sub-) dependency in electron-store accordingly?

Using the overrides feature of npm as follows leads to below error:

"overrides": {
  "dot-prop": "7.2.0"
 }

Uncaught Exception: Error [ERR_REQUIRE_ESM]: require() of ES Module

Cheers, Raphael

sindresorhus commented 1 year ago

dot-prop 7 requires ESM and Electron does not yet support that. This issue is blocked by https://github.com/electron/electron/pull/37535.

iamterryclark commented 11 months ago

Hasn't this been merged in to electron now?

Are there plans to update electron-store in the future?