sindresorhus / electron-unhandled

Catch unhandled errors and promise rejections in your Electron app
MIT License
448 stars 26 forks source link

Fix Electron 6 compatibility #12

Closed jmerle closed 5 years ago

jmerle commented 5 years ago

The dialog.showMessageBox method has been split into dialog.showMessageBox and dialog.showMessageBoxSync in Electron 6.0.0. This PR ensures that the sync variant is used in Electron >=6 without breaking compatibility with Electron <6.

I have no idea how to add tests for a change like this though, help is very much welcome.