search

sindresorhus / electron-util

Useful utilities for Electron apps and modules
MIT License
1.28k stars 63 forks source link

Fix `enforceMacOSAppLocation` crash #29

Closed kaatt closed 4 years ago

kaatt commented 4 years ago

showMessageBox returns a promise so it always moved the app to the Applications folder regardless of user selection. In certain cases this crashed the app.

sindresorhus commented 4 years ago

Have you manually tested this change?

kaatt commented 4 years ago

Nope, will test and comment

kaatt commented 4 years ago

It works.

However I still see the crash reporter on macOS for the previous instance that was closed. Not sure if it's my code or an issue with this module or electron v9.

sindresorhus commented 4 years ago

However I still see the crash reporter on macOS for the previous instance that was closed. Not sure if it's my code or an issue with this module or electron v9.

I don't know. Let me know if you figure it out.