sindresorhus / electron-util

Useful utilities for Electron apps and modules
MIT License
1.28k stars 63 forks source link

feat: updates for Electron 10 #34

Closed evereq closed 3 years ago

sindresorhus commented 4 years ago

You need to update the JS file and readme too.

evereq commented 4 years ago

@sindresorhus what exactly should be updated there? In Readme, I can't found anything related to the version of Electron (sorry if missed something), and in JS files I also not sure what is needed to be changed? We only removed type usage that was removed from Electron 10...
If you can provide any hints, we will be glad to update PR.

CC: @syns2191

sindresorhus commented 4 years ago

The types changed because the API changed. I would recommend reading the Electron 10 release notes.

sindresorhus commented 3 years ago

Closing in favor of #36