search

sindresorhus / electron-util

Useful utilities for Electron apps and modules
MIT License
1.28k stars 63 forks source link

Improve the default look of `showAboutWindow()` on Linux and Windows #50

Closed mquevill closed 3 years ago

mquevill commented 3 years ago

Since defaults don't exist for Linux in the base Electron package (https://github.com/electron/electron/issues/18918), I figure that showAboutWindow() could set some of these defaults and then use the standard About dialog. Until the defaults are standardized by the Electron (https://github.com/electron/electron/issues/23851), this would be a way to get consistency across Windows and Linux.

The documentation would need to be updated to reflect these changes, which I can add after the changes are finalized.

Example using Caprine: About window on main branch: about_old With this PR: about_new Adding copyright and website to Caprine's about menu: about_added

[Note: This does not fix the icon getting messed up when packaged into a .deb file.]

Perhaps the defaults set here should be marked with a TODO comment while waiting for Electron to set defaults?

sindresorhus commented 3 years ago

Perhaps the defaults set here should be marked with a TODO comment while waiting for Electron to set defaults?

👍 Always good to add TODOs for future possible improvements (and include links to relevant issues)

sindresorhus commented 3 years ago

I'm ok with this. Feel free to update the docs (and index.d.ts)