search

sindresorhus / emoj

Find relevant emoji from text on the command-line :open_mouth: :sparkles: :raised_hands: :horse: :boom: :see_no_evil:
MIT License
2.36k stars 58 forks source link

Enhance 3rd party result with local information #30

Closed steveoh closed 4 years ago

steveoh commented 7 years ago

Issuehunt badges

Some emoji's just aren't findable with the 3rd party service. For instance https://github.com/sindresorhus/alfred-emoj/issues/14. What would it take to enhance the results?

Could we bundle a local db to add emoji that are hard to find or just aren't in the 3rd party service?

IssueHunt Summary #### [stroncium stroncium](https://issuehunt.io/u/stroncium) has been rewarded. ### Backers (Total: $80.00) - [issuehunt issuehunt](https://issuehunt.io/u/issuehunt) ($80.00) ### Submitted pull Requests - [#39 solves #30](https://issuehunt.io/r/sindresorhus/emoj/pull/39) - [#40 Add `emojilib` to enhance results](https://issuehunt.io/r/sindresorhus/emoj/pull/40) --- ### Tips - Checkout the [Issuehunt explorer](https://issuehunt.io/r/sindresorhus/emoj/) to discover more funded issues. - Need some help from other developers? [Add your repositories](https://issuehunt.io/r/new) on IssueHunt to raise funds. --- IssueHunt has been backed by the following sponsors. [Become a sponsor](https://issuehunt.io/membership/members)
sindresorhus commented 7 years ago

We could include results from the local DB in case of exact match. Could use https://github.com/muan/emojilib for this.

Pull request welcome if anyone wants to work on this :)

steveoh commented 7 years ago

I like the idea. Nice find on the package. I'll create a pull request as dibs when I get motivated to add emojilib.

mesqueeb commented 5 years ago

Just +1'ing here so I can get any updates on this! ;)

mesqueeb commented 5 years ago

BTW, you use this API? https://getdango.com/api/ Is it a paid tier? Maybe I could also open an issue there.

sindresorhus commented 5 years ago

@mesqueeb No, we're using a different private API from them under their permission.

IssueHuntBot commented 5 years ago

@issuehunt has funded $80.00 to this issue.

satyarohith commented 5 years ago

Working on this!

mesqueeb commented 5 years ago

Hmm, it seems that ever since March 2019 this issue was solved via two PR's:

So I guess @sindresorhus now just must pick one and merge it to close this issue?

issuehunt-oss[bot] commented 4 years ago

@sindresorhus has rewarded $72.00 to @stroncium. See it on IssueHunt