Add `emojilib` to enhance results

sindresorhus / emoj

Find relevant emoji from text on the command-line :open_mouth: :sparkles: :raised_hands: :horse: :boom: :see_no_evil:

MIT License

2.37k stars 58 forks source link

Add `emojilib` to enhance results #40

Closed satyarohith closed 4 years ago

satyarohith commented 5 years ago

closes #30

IssueHunt Summary

### Referenced issues This pull request has been submitted to: - [#30: Enhance 3rd party result with local information](https://issuehunt.io/repos/61745494/issues/30) --- IssueHunt has been backed by the following sponsors. [Become a sponsor](https://issuehunt.io/membership/members)

mesqueeb commented 5 years ago

@satyarohith hi! Can I test this locally? I'd love to test it 😉

_{Sent with GitHawk}

satyarohith commented 5 years ago

@mesqueeb Yes, you can test it. The only thing missing is offline support.

satyarohith commented 5 years ago

@sindresorhus Any thoughts on offline support (i.e. search without internet connection)? To support this feature, we need to do a little refactor but I don't think it will be worth it because most of the time everyone is connected to the internet. Let me know what you think. I will dig in if you think it's useful.

revelt commented 5 years ago

@sindresorhus please advise ^

mesqueeb commented 5 years ago

Why not merge this PR and open a new ticket for offline support. Then we can already start using this feature and adding offline support or not can be decided in the new ticket. ;)