search

sindresorhus / eslint-plugin-unicorn

More than 100 powerful ESLint rules
MIT License
4.28k stars 367 forks source link

Maintenance todo list #1778

Open fisker opened 2 years ago

fisker commented 2 years ago

Rename no-array-for-each to no-for-each.

It's actually check other types, Set (Buggy #1452), Map, NodeList etc

sindresorhus commented 2 years ago

Makes sense, but not sure it's worth the effort or churn. Maybe we should just collect it in a list and do multiple renames in a batch when we have some more? As a user, it's better to handle multiple deprecations in one go instead of multiple times.

fisker commented 2 years ago

Let's postpone this. We can do it when we get enough rules to rename/deprecate. I'll keep this open.

fisker commented 10 months ago

Another rule rename idea, prevent-abbreviations should renamed as no-abbreviations.

fregante commented 9 months ago

prevent-abbreviations should renamed as no-abbreviations

As the description suggests, the rule doesn't necessarily only work on abbreviations, so maybe it should be called text-replacements (it'd match macOS/iOS naming)

fisker commented 7 months ago

Deprecate prefer-node-protocol , since it's adopted by eslint-plugin-n https://github.com/eslint-community/eslint-plugin-n/blob/master/docs/rules/prefer-node-protocol.md