search

sindresorhus / eslint-plugin-unicorn

More than 100 powerful ESLint rules
MIT License
3.98k stars 361 forks source link

prefer-node-protocol: ignore bun modules #2384

Closed SunsetTechuila closed 2 weeks ago

SunsetTechuila commented 2 weeks ago

fixes #2383

sindresorhus commented 2 weeks ago

This is already how the latest version of the existing package works. It requires ESM, so we would need to either inline it or wait for https://github.com/sindresorhus/eslint-plugin-unicorn/issues/2278. I'm not interested in switching to is-core-module.

SunsetTechuila commented 2 weeks ago

This is already how the latest version of the existing package works. It requires ESM

i know

wait for https://github.com/sindresorhus/eslint-plugin-unicorn/issues/2278

it may take a long time

I'm not interested in switching to is-core-module.

then, will it be okay if i do this for now?

|| value.match(/^bun(:\w+|$)/)
SunsetTechuila commented 2 weeks ago

@sindresorhus hello, would appreciate your answer

sindresorhus commented 2 weeks ago

will it be okay if i do this for now?

👍

SunsetTechuila commented 2 weeks ago

@sindresorhus done