Fix Node.js without ICU support

ehmicky commented 1 month ago

Fixes #1143.

This PR does not add any documentation because this is a very tiny edge case that almost nobody will encounter:

Running Node.js without ICU support requires building your own Node.js binary. No pre-built binary without ICU support seems to be available.
Then, the user would need to use very special characters in the command, such as isolated surrogate characters or reserve Unicode codepoints (which is quite unlikely) to notice any difference.
Even then, the only difference would only be that those special characters would be printed as is on the terminal (when using result.escapedCommand) instead of being represented as a backslash sequence \u..., which is not a big problem.

Uzlopak commented 1 month ago

When will it be released? :)

ehmicky commented 1 month ago

This has now been released in 9.3.1. Thanks again for your help.

Is this working?

Uzlopak commented 1 month ago

Thank you. Yes :). Great Success.

ehmicky commented 1 month ago

Thanks for the shout out @Uzlopak, that's very kind! :pray:

Uzlopak commented 1 month ago

Unfortunately, you are not on twitter, or else I would have linked you.

sindresorhus / execa