search

sindresorhus / fast-cli

Test your download and upload speed using fast.com
MIT License
2.58k stars 110 forks source link

Add puppeteer executable path option #60

Closed aoki closed 3 years ago

aoki commented 3 years ago

Add puppeteer executable path option for #59 . I tested on Raspberry Pi after install chromium-browser (apt install chromium-browser) using bellow command.

node cli.js --puppeteer-executable /usr/bin/chromium-browser

And please tell me words if you have good name for option and variable.

OS Information

$ cat /proc/device-tree/model
Raspberry Pi 2 Model B Rev 1.1

$ cat /etc/os-release
PRETTY_NAME="Raspbian GNU/Linux 10 (buster)"
NAME="Raspbian GNU/Linux"
VERSION_ID="10"
VERSION="10 (buster)"
VERSION_CODENAME=buster
ID=raspbian
ID_LIKE=debian
HOME_URL="http://www.raspbian.org/"
SUPPORT_URL="http://www.raspbian.org/RaspbianForums"
BUG_REPORT_URL="http://www.raspbian.org/RaspbianBugs"
sindresorhus commented 3 years ago

I'm not interested in adding any flags for this, but if you can come up with a solid way to handle this cause automatically, I'm willing to merge that.

aoki commented 3 years ago

Thank you for your response.

I agree to your opinion. I like simple interface and should keep it. I will consider this problem again. Therefore this PR close.

Thanks!