search

sindresorhus / file-type

Detect the file type of a file, stream, or data
MIT License
3.64k stars 345 forks source link

Replace node:buffer usage with Uint8Array #633

Closed bjornstar closed 2 months ago

bjornstar commented 2 months ago

It's time to say Goodbye, node.js Buffer in this library.

Resolves #578

Dependencies

~This was an interesting challenge. Please hold while I raise PRs to these two dependencies.~

~Update: PRs raised for both dependencies, I'll come back and update this once they're merged and released.~

Update: Both dependencies have been updated and released.

Borewit commented 2 months ago

I run all music-metadata with success local against 4caaee2, as reported https://github.com/Borewit/music-metadata/pull/2103#issuecomment-2198304586, which gives me confidence that the dependent changes in strtok3 and token-types are good.

bjornstar commented 2 months ago

token-types has been updated. This should be good to go.