Closed Borewit closed 1 month ago
You also need to update the doc comments in the types.
Some of my suggested changes were not applied. It would have been better to simply commit the changes directly (they are diff suggestions, so you could have just pressed "commit suggestion").
There are still missed things, like https://github.com/sindresorhus/file-type/pull/641#discussion_r1673134960
Improve documentation of:
fileTypeFromFile(filePath)
: explain this method can only be used if the JavaScript engine is Node.jsfileTypeFromStream(stream)
explain that Node.js stream is only available when used with Node.jsfileTypeFromBlob(blob)
explain that this is the method to used for web API FileResolves #640