search

sindresorhus / find-up

Find a file or directory by walking up parent directories
MIT License
582 stars 40 forks source link

The Typescript declaration file isn't installed even though it exists in the repository #39

Closed ChristianIvicevic closed 5 years ago

ChristianIvicevic commented 5 years ago

I just installed this package via yarn as usual running yarn add find-up but compared to you other packages the typings file isn't in the installed package under node_modules even though I can see it in the repository. Could you please look into this, whether your able to reproduce this issue?

ChristianIvicevic commented 5 years ago

Please disregard this issue, I am using yarn workspaces and find-up gets hoisted with a previously available version that I did not expect. This is most likely something I can only fix in the context of my project.

ChristianIvicevic commented 5 years ago

Oh I was wrong, it turns out, you just recently added the typings without publishing a new version to npm. In the meantime I have added the Github repo as a repository and I'd be glad if you can push a new update to npm with the typings included.

issuehunt-oss[bot] commented 5 years ago

pong

sholladay commented 5 years ago

Yep, we just need to do a release. We will be doing a major release (v4.0.0) and it's blocked by #33 because we plan to make type: file be the default behavior.

ChristianIvicevic commented 5 years ago

@sholladay @sindresorhus I have been running into issues since I have added the Github repository as a dependency to my current project instead of the npm package just to get the typings. Unfortunately my CI pipeline is having issues with Github dependencies and concurrent installations of the same dependency and thus fails.

Can you please publish a 3.0.1 version, with the typings included so I can directly install via npm?

sindresorhus commented 5 years ago

@ChristianIvicevic We will publish a new version when it's ready. You can just use @types/find-up with the current version of find-up on npm.