search

sindresorhus / fkill-cli

Fabulously kill processes. Cross-platform.
MIT License
6.88k stars 159 forks source link

Process is not killed #42

Closed capaj closed 3 years ago

capaj commented 6 years ago

Issuehunt badges

I have a node.js process listening on port 3000 and I can't kill it. image

Ubunut 17.10 Node 8.9.3

IssueHunt Summary #### [stroncium stroncium](https://issuehunt.io/u/stroncium) has been rewarded. ### Backers (Total: $40.00) - [issuehunt issuehunt](https://issuehunt.io/u/issuehunt) ($40.00) ### Submitted pull Requests - [#80 Add `--force-after-timeout` / `-t` option](https://issuehunt.io/r/sindresorhus/fkill-cli/pull/80) --- ### Tips - Checkout the [Issuehunt explorer](https://issuehunt.io/r/sindresorhus/fkill-cli/) to discover more funded issues. - Need some help from other developers? [Add your repositories](https://issuehunt.io/r/new) on IssueHunt to raise funds.
curtisbelt commented 6 years ago

fkill :3000 -f

capaj commented 6 years ago

it would be nice if fkill would reflect the fact that it did not kill the process in the output. Also IMHO the default to forcibly kill it would make more sense to me. I mean if someone is installing fkill it is because they want to kill processes, not just ask them nicely to terminate.

sindresorhus commented 6 years ago

In the interactive interface, we detect if the process was killed or not and ask the user if they want to force kill. When using the non-interactive interface, like here, we could try to force kill if normal killing didn't work.

IssueHuntBot commented 5 years ago

@issuehunt has funded $40.00 to this issue. See it on IssueHunt

medusalix commented 5 years ago

When using the non-interactive interface, like here, we could try to force kill if normal killing didn't work.

@sindresorhus Should we introduce a new flag for this behavior? Something like safe-kill? We could also just notify the user that a process is going to get killed forcibly when normal killing didn't work.

sindresorhus commented 5 years ago

I think we should try killing normally first and if that fails, we should force kill.

thepont commented 5 years ago

@sindresorhus that makes the assumption that fkill knows how long the process takes to cleanly shutdown. Perhaps if it prompts the user so they know they are about the rip the life from the process without giving it time to clean up.

sindresorhus commented 4 years ago

If anyone wants to work on this, see the initial attempt and feedback here: https://github.com/sindresorhus/fkill-cli/pull/70

sindresorhus commented 4 years ago

This is blocked by https://github.com/sindresorhus/fkill/issues/44

sindresorhus commented 3 years ago

Abandoned attempt: https://github.com/sindresorhus/fkill-cli/pull/76

issuehunt-oss[bot] commented 3 years ago

@sindresorhus has rewarded $36.00 to @stroncium. See it on IssueHunt