search

sindresorhus / fkill-cli

Fabulously kill processes. Cross-platform.
MIT License
6.88k stars 159 forks source link

Display all ports used by process #47

Closed kevva closed 6 years ago

kevva commented 6 years ago
screen shot 2018-03-22 at 13 14 26

Fixes #39.

sindresorhus commented 6 years ago

Looks good. Can you fix the conflict?

kevva commented 6 years ago

Yup, what do you want to do with the truncating of the name? Currently it looks like this for Google Chrome:

screen shot 2018-03-22 at 13 58 13
sindresorhus commented 6 years ago

I think we just limit it to the width of the terminal and just do … after. No point in showing this many ports. Could maybe use https://github.com/sindresorhus/cli-truncate

sindresorhus commented 6 years ago

Hmm, or not. We should truncate it on spaces, not in the middle of a port.

kevva commented 6 years ago

Hmm, or not. We should truncate it on spaces, not in the middle of a port.

Would this make sense as an option in https://github.com/sindresorhus/cli-truncate? Or maybe add space to the position option.

sindresorhus commented 6 years ago

Would this make sense as an option in sindresorhus/cli-truncate?

Yes, something like {preferBreakingOnSpaces: true}. If there are no spaces or it has to break more than half the line to do it, it should just truncate normally. Need a better name than preferBreakingOnSpaces though.

sindresorhus commented 6 years ago

cli-truncate issue: https://github.com/sindresorhus/cli-truncate/issues/8