sindresorhus / generate-github-markdown-css

Generate the CSS for github-markdown-css
MIT License
380 stars 77 forks source link

Fix workaround with GitHub latest styles #28

Closed hyrious closed 10 months ago

hyrious commented 10 months ago

This PR did various changes to make it work with the latest styles from GitHub.

To read the output diff:

$ node test
$ wget https://cdn.jsdelivr.net/npm/github-markdown-css/github-markdown.css
$ git diff --no-index github-markdown.css dist/auto.css

Next steps:

As I mentioned in #27, GitHub will use newer CSS syntaxes from now on -- they are using @container, maybe the next is @layer or even CSS nestings. We need not a workaround but a solution to parse these new CSS syntaxes. Maybe integrating lightningcss, or making a fork of the css module to add supports (it is not updated for 2 years).

sindresorhus commented 10 months ago

Maybe integrating lightningcss, or making a fork of the css module to add supports (it is not updated for 2 years).

I think we should switch. CSS doesn't stop evolving, so it doesn't make sense to continue maintenance of an abandoned package.