search

sindresorhus / generate-github-markdown-css

Generate the CSS for github-markdown-css
MIT License
380 stars 77 forks source link

Include styles for user/team mentions #8

Closed kj800x closed 4 years ago

kj800x commented 4 years ago

Description

The styling of user/team mentions is different between github-markdown-css and the actual styling on GitHub. I'm not sure if there is an easy fix, since I don't think you can mention a user or team in your fixture.md; this styling seems to only apply in the body of pull requests/issues/comments.

My coworkers identified at least some of the missing styles:

.team-mention, .user-mention {
    font-weight: 600;
    color: #24292e;
    white-space: nowrap;
}

github-markdown-css styles:

Screen Shot 2020-04-29 at 5 59 09 PM

Actual GitHub styles:

Screen Shot 2020-04-29 at 6 00 32 PM

/cc @also @jhilker

kj800x commented 4 years ago

I also just noted that PR bodies have a comment-body class which is why the font size wasn't matching up either.

.comment-body {
  font-size: 14px;
}
sindresorhus commented 4 years ago

That's is outside the scope of this project. The intention is to replicate the readme style, not other GitHub UI styles.