Added new option question 'tabs' to decide if you want to indent with tabs or spaces

jefflindholm commented 5 years ago

Added editorconfig-spaces as the editorconfig to use with spaces Added 2 tests - 1 to ensure old functionality, 2 to ensure new tabs works for choosing spaces

Prettier reformated index a tad

Added 2 rules to package.json

comma-dangle for alwas multi line (makes diffs much cleaner when adding items)
obejct-curly-spacing for the one thing prettier above changed to make objects stand out a bit

sindresorhus commented 5 years ago

I appreciate the PR, but it's not something I'm interested in maintaining. I would be happy to link to your fork if you decide to publish and maintain it though.

jefflindholm commented 5 years ago

OK thanks

On Mon, May 20, 2019 at 2:27 PM Sindre Sorhus notifications@github.com wrote:

@sindresorhus commented on this pull request.

In app/templates/editorconfig-spaces https://github.com/sindresorhus/generator-nm/pull/80#discussion_r285715981 :

@@ -0,0 +1,15 @@ +root = true + +[] +indent_style = space +end_of_line = lf +charset = utf-8 +trim_trailing_whitespace = true +insert_final_newline = true + +[.yml] +indent_style = space +indent_size = 2

You also need to prompt whether it should be 2 or 4 spaces. 4 spaces if actually quite common in the JS world.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sindresorhus/generator-nm/pull/80?email_source=notifications&email_token=AABDTW5UJWYWLXGZH74IFW3PWLUQLA5CNFSM4HODV6B2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOBZEN4JY#pullrequestreview-239656487, or mute the thread https://github.com/notifications/unsubscribe-auth/AABDTW3Y5L576JFQP2ZPWO3PWLUQLANCNFSM4HODV6BQ .

sindresorhus / generator-nm

Added new option question 'tabs' to decide if you want to indent with tabs or spaces #80

@sindresorhus commented on this pull request.