search

sindresorhus / generator-nm

Scaffold out a node module
MIT License
743 stars 82 forks source link

humanizeUrl is redundant. Creates invalid URI #83

Closed rocktimsaikia closed 4 years ago

rocktimsaikia commented 4 years ago

I was using this generator and noticed that it strictly turns valid URI to normal string without no http. I don't know if this was intentional but I looked through the code and seems like it's just a redundant package and creates an extra URL warning. There is already a normalizeUrl package. We can use that instead of humanizeUrl

issue

sindresorhus commented 4 years ago

Agreed. I don't remember why I used it there.

rocktimsaikia commented 4 years ago

@sindresorhus made a pull request #84 . You can review whenever you are free !