search

sindresorhus / get-stream

Get a stream as a string, Buffer, ArrayBuffer or array
MIT License
341 stars 33 forks source link

Avoid using `setEncoding` #10

Closed jamestalmage closed 8 years ago

jamestalmage commented 8 years ago

I think calling setEncoding affects the data received by other data listeners:

var stream = someStream();
stream.on('data', chunk => assert(Buffer.isBuffer(chunk)));

// vs

var stream = someStream();
var p = getStream(stream);
stream.on('data', chunk => assert(typeof chunk === 'string'));

Perhaps it would be better to pipe to a PassThrough stream, and listen to that.

kevva commented 8 years ago

Fixed in https://github.com/sindresorhus/get-stream/commit/607623b733f85980a52d8ea89d8da0406bb700a5.