I checked Node.js default iterable Readable[Symbol.asyncIterator] (source here), for comparison.
I believe the new behavior to be fairly close to the previous behavior, except that multiple concurrent readers are now possible. That being said, there are slight differences, such as:
Some error thrown in an edge case having a different error.code
Some iterations processing smaller chunks at a time
And other minor details
For most users, this should not matter, but to be on the safe side, this probably should be in a major release. We probably should try to solve https://github.com/sindresorhus/get-stream/issues/116 as part of that major release (I am looking into it right now).
Note: to double check, I also ran this PR against Execa automated tests, and they all passed.
Fixes #119.
I checked Node.js default iterable
Readable[Symbol.asyncIterator](source here), for comparison.I believe the new behavior to be fairly close to the previous behavior, except that multiple concurrent readers are now possible. That being said, there are slight differences, such as:
errorthrown in an edge case having a differenterror.codeFor most users, this should not matter, but to be on the safe side, this probably should be in a major release. We probably should try to solve https://github.com/sindresorhus/get-stream/issues/116 as part of that major release (I am looking into it right now).
Note: to double check, I also ran this PR against Execa automated tests, and they all passed.