Closed miniben-90 closed 1 year ago
Thanks for working on this. Make sure you look over your own diff and try to improve it. This will save me time so I don't have to point out lots of nitpick stuff.
Maybe you can find some inspiration here: https://github.com/glsorre/amethystwindows/blob/340d54a076b8c04e74b5f096af7c34b5c2f41ba5/AmethystWindows/DesktopWindowsManager/DesktopWindow.cs#L28-L36
Basically, this search: https://github.com/search?q=dwmapi.DwmGetWindowAttribute+DWMWA_CLOAKED&type=code
Hi,
I added the modification to filter for win32 system like your links (I use this https://stackoverflow.com/a/62126899 to help me with the condition). He's code work like alt+tab
of Microsoft and return only window who are not cloaked or it's not a window toolbar.
Can you be more specific about your links?
Can you be more specific about your links?
The projects I linked to are mature and have a lot of code to handle edge-cases. We can borrow some of that, which are the lines I linked to.
I make some big breaking change for windows cause of a issue with ffi-napi end Workers. I change it for a native node addon (with node-addon-api, node-gyp).
I also change your main.yml to update version and add node 18 to the test.
I created a release.yml file to generate binary for windows at release (it's important to change version of package.json before a release).
For your previous links, it's not logical to filter with className (example with terminal), I just keep the idea of the last link.
This is starting to look good. Although, I'm not super excited to have to maintain C++ code. I would much have preferred Rust and https://napi.rs. Which would have made the code easier to maintain, read, and build.
This is starting to look good. Although, I'm not super excited to have to maintain C++ code. I would much have preferred Rust and https://napi.rs. Which would have made the code easier to maintain, read, and build.
Unfortunately, I don't have time to learn a new language at the moment. But you are welcome to make the change on the basis of the main.cc :).
@miniben-90 The binary publish step failed: https://github.com/sindresorhus/active-win/actions/runs/3686184879
@miniben-90 Different failure: https://github.com/sindresorhus/active-win/actions/runs/3686737172
Why
In my case I need to have access to the active window and the list of open windows.
Changes
Map<string, {processes: activeWindow.Result[]}>