search

sindresorhus / get-windows

Get metadata about the active window and open windows (title, id, bounds, owner, etc)
MIT License
798 stars 166 forks source link

Build and release process question #167

Closed wrgoto closed 1 year ago

wrgoto commented 1 year ago

Hey @sindresorhus, thanks for maintaining such a great library. What are the steps to build and publish the newest version? We're trying to build from our fork and have some questions. I see that when you create a release, GitHub Actions builds the Windows binaries. Do you build the macOS locally, add the Windows binaries to lib/binding and then publish?

sindresorhus commented 1 year ago

The macOS binary is built at publish time: https://github.com/sindresorhus/active-win/blob/27221e5da0a64025bdec8759605694ea84ff9f68/package.json#L38

The Windows binaries are built with GitHub Actions and automatically added to the GitHub release: https://github.com/sindresorhus/active-win/blob/main/.github/workflows/release.yml

wrgoto commented 1 year ago

@sindresorhus Why aren't you adding the macOS binaries to the GitHub release?

sindresorhus commented 1 year ago

For simplicity. It's easier to just embed it in the package.