search

sindresorhus / get-windows

Get metadata about the active window and open windows (title, id, bounds, owner, etc)
MIT License
797 stars 167 forks source link

Update for Electron 8 #70

Closed wgcv closed 4 years ago

wgcv commented 4 years ago

Fixes https://github.com/sindresorhus/active-win/issues/68 solved by: @timsu

sindresorhus commented 4 years ago

Can you open an issue on ref-napi or Electron?

johndalangin commented 4 years ago

Hi @sindresorhus

Confirming that this PR indeed fixes the Electron 8. Would there be any concerns to consider before merging this?

Thank you and stay safe.

sindresorhus commented 4 years ago

Yes, when someone does what I commented above. I'm not going to merge a workaround without knowing that it's reported so it can be fixed in the future and the workaround can be reverted.

johndalangin commented 4 years ago

Understood thanks 🙏

srsholmes commented 4 years ago

@johndalangin @wgcv @timsu Any update on the request of "Can you open an issue on ref-napi or Electron?"

I'm happy to open the issue, but dont want to duplicate it. Also I dont exactly know what the issue was and how it was solved. It would be good to get this merged when the issue has been opened.

wgcv commented 4 years ago

I didn't open a issue.

johndalangin commented 4 years ago

@srsholmes I also didn't open an issue as I have limited understanding of the specifics at the moment to credibly open one.

sindresorhus commented 4 years ago

https://github.com/sindresorhus/active-win/issues/68#issuecomment-654167089