search

sindresorhus / get-windows

Get metadata about the active window and open windows (title, id, bounds, owner, etc)
MIT License
797 stars 167 forks source link

Add `screenRecordingPermission` option #96

Closed wrgoto closed 3 years ago

wrgoto commented 3 years ago

Why

One of the significant drawbacks is the library asking for Screen Recording permissions for macOS versions 10.15 and newer. Even though the library doesn't actually record the screen, it is required to get the title of the active window. For those who do not need the window title, there should be an option to forgo the Screen Recording permission check.

Changes

Related

sindresorhus commented 3 years ago

See the feedback in https://github.com/sindresorhus/active-win/pull/67. There should be an option for each check.

achuinard commented 3 years ago

@wrgoto Thanks for your contributions!

wrgoto commented 3 years ago

@sindresorhus I agree there should be an option for each check, but I haven't verified the extent of removing the accessibility check. I'm not entirely sure if it is limited to the url property. I can investigate in a separate issue and PR.

achuinard commented 3 years ago

@sindresorhus are you looking to get this merged soon?

sindresorhus commented 3 years ago

The PR title needs to be updated.