search

sindresorhus / github-markdown-css

The minimal amount of CSS to replicate the GitHub Markdown style
https://sindresorhus.com/github-markdown-css
MIT License
7.99k stars 2.1k forks source link

github-markdown-css is not AMP compatible #72

Closed davidbelow closed 4 years ago

davidbelow commented 4 years ago

Feature request

First of all thanks for your work at github-markdown-css, @sindresorhus.

Related Problem

When using github-markdown-css with Next.js AMP the AMP validator throws an error: "Disallowed !important attribute in CSS".

Solution

github-markdown-css is AMP compatible.

Alternatives

If github-markdown-css cannot be AMP compatible then offering a github-markdown-css-amp could be an alternative.

sindresorhus commented 4 years ago

The CSS is generated. See the readme. And it's just normal CSS. The fact that AMP doesn't allow !important is not really a concern for this package. You're of course free to fork and publish an AMP compatible version if you want.